Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: Create Card UI component #4690

Closed
wants to merge 17 commits into from
Closed

tech: Create Card UI component #4690

wants to merge 17 commits into from

Conversation

Youakeem
Copy link
Contributor

@Youakeem Youakeem commented Sep 12, 2024 •
edited
Loading

Describe your changes

  • Renamed ProductCardBlock to ProductGridItemBlock
  • Create IconButton component
  • Create BasePillow UI component and use in the Pillow component
  • Create generic Card UI component

Justify why they are needed

  • Align ProductCard naming with Figma
  • Needed for the Card component
  • So we can use BasePillow in the UI package without the Next Image component
  • Generic Card component to compose other Cards like ProductCard and PriceCalculatorCard

Checklist before requesting a review

  • I have performed a self-review of my code

@Youakeem
Update Storybook
958df43
@Youakeem
Revert "Update Storybook"
33e6066 
This reverts commit e8ef13a98e3564a115e1a485612eb36f0bf9b0af.
@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview Sep 13, 2024 3:46pm

@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Youakeem and the rest of your teammates on Graphite Graphite

@Youakeem Youakeem changed the title Update Storybook tech: Create Card UI component Sep 13, 2024
@Youakeem Youakeem marked this pull request as ready for review September 13, 2024 13:20
@Youakeem Youakeem requested a review from a team as a code owner September 13, 2024 13:20
This was referenced Sep 13, 2024
Merged
Merged
This was referenced Sep 13, 2024
Merged
Merged
Merged
alebedev
alebedev reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@alebedev alebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like few independent changes collapsed into single PR. Can you split it into several smaller PRs? For example, Tooltip, BasePillow, IconButton, Card, etc

@Youakeem Graphite App
Copy link
Contributor Author

This looks like few independent changes collapsed into single PR. Can you split it into several smaller PRs? For example, Tooltip, BasePillow, IconButton, Card, etc

True! I realized that a little late. Will get back to it and try to split it up.

@Youakeem Youakeem closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alebedev alebedev alebedev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youakeem @alebedev